feat: add Secret Manager#2678
Open
rmnbrd wants to merge 76 commits into
Open
Conversation
0286b11 to
2d1f40b
Compare
- move secret manager exports into a dedicated subfolder - update add-on step imports to use the new barrel
aedb64e to
6cd95bf
Compare
12 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2678 +/- ##
===========================================
+ Coverage 45.86% 45.93% +0.06%
===========================================
Files 1164 1197 +33
Lines 24497 25430 +933
Branches 7196 7520 +324
===========================================
+ Hits 11236 11681 +445
- Misses 11299 11700 +401
- Partials 1962 2049 +87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR implementing the Secret Manager feature.
Screenshots / Recordings
Branch Diff Summary
This branch introduces External Secrets / Secret Manager integration as a major feature, along with several supporting improvements.
🔑 Core Feature: External Secrets & Secret Manager Integration
New
@qovery/shared/util-clusterslibrary — Pure utility functions for cluster/secret manager logic (AWS/GCP detection, integration constraint checks, readable labels, etc.).Secret Manager modals (
libs/domains/clusters/feature):SecretManagerIntegrationModal— Full form for configuring AWS/GCP secret managers with automatic vs. manual tabs, STS assume role, static credentials, GCP JSON credentials, and constraint logic (e.g., automatic + assume role are mutually exclusive).SecretManagerAssociatedExternalSecretsModal— Tree-view modal showing which services use a given secret manager.SecretManagerList/AddonToggleCard— Reusable components for managing the list of configured secret managers.New API queries in
clustersdata-access:listSecretManagerSecretsFromProvider— autocomplete/search for secret names.listSecretManagerAssociatedServices— shows what's using a secret manager.🧩 Cluster Add-ons Page (new route)
Two new routes at
/cluster/$clusterId/settings/addons(settings) and/cluster/create/$slug/addons(creation flow):StepSummarynow includes add-on data in the cluster creation payload.addonsDatacontext state and the step count increases by 1 for AWS/GCP managed clusters.📋 Variables Page Refactor (tabs)
Both the environment and service Variables pages were converted from single-page to a tabbed layout:
/variables//variables/external-secrets/variables/built-invariables.tsxfiles deleted; replaced byvariables/route.tsx(layout) +index.tsx/built-in.tsx/external-secrets.tsxsub-routes.ExternalSecretsTab— Full TanStack Table with search, filter, sort, bulk delete, and add/edit modals wired touseCreateVariable/useEditVariable.secret-managerPostHog feature flag.🛠️
VariableListRefactorshowOnly('custom' | 'built-in'),hideSectionLabel,headerActions.🆕 Service Creation Flow — Variables Step
The application/container creation step-variables was rewritten:
FlowCreateVariablewith a custom inline table UI.secret-managerflag is on and a secret manager is linked to the cluster).StepSummarynow creates external secret variables viauseCreateVariableafter service creation (errors are non-blocking viaPromise.allSettled).🗂️
AssociatedItemsModalRefactoringLabelAnnotationItemsListModalwas generalized intoAssociatedItemsModalwith genericAssociatedItemtype, customizable title/placeholder/item label — now reused by both the labels/annotations feature and the secret manager feature.🔧 Other Changes
CreateUpdateVariableModalsplit: API-backed wrapper kept, newVariableFormModalextracted for use in creation flows (before a service exists).VariablesActionToolbargainsshowDopplerButtonandhasClusterSecretManagerConfiguredprops.StickyActionFormToastergainsfixedmode (used in tab layouts).TableFilterSearchgains configurableplaceholderand consistent sizing.TableFilterdropdown truncates long option labels.Navbar.Itemnow hascursor-pointerby default.InputSelectsupportsdisabledTooltipon individual options.negativeInvert,surface.negativeInvert,background-invert-1.qovery-typescript-axiosbumped1.1.891 → 1.1.893.cluster.router.tsconstants file deleted (inline paths used instead).Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release