Skip to content

feat(actions): reduce confirmation friction#2595

Merged
RemiBonnet merged 6 commits intonew-navigationfrom
feat/new-nav/reduce-confirmation-friction
Apr 14, 2026
Merged

feat(actions): reduce confirmation friction#2595
RemiBonnet merged 6 commits intonew-navigationfrom
feat/new-nav/reduce-confirmation-friction

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 13, 2026

Summary

https://qovery.slack.com/archives/C0A3EJJ1YAX/p1776089284446679

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet force-pushed the feat/new-nav/reduce-confirmation-friction branch from 96ca789 to ee069c4 Compare April 13, 2026 15:20
@RemiBonnet RemiBonnet marked this pull request as ready for review April 13, 2026 15:26
@RemiBonnet RemiBonnet added the V5 label Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@7b7ff67). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../lib/service-remove-modal/service-remove-modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2595   +/-   ##
=================================================
  Coverage                  ?   45.14%           
=================================================
  Files                     ?     1063           
  Lines                     ?    21989           
  Branches                  ?     6452           
=================================================
  Hits                      ?     9928           
  Misses                    ?    10275           
  Partials                  ?     1786           
Flag Coverage Δ
unittests 45.14% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RemiBonnet RemiBonnet force-pushed the feat/new-nav/reduce-confirmation-friction branch from 4ea1007 to 75b36f7 Compare April 14, 2026 12:39
@RemiBonnet RemiBonnet merged commit 5f9dd73 into new-navigation Apr 14, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/reduce-confirmation-friction branch April 14, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants