fix(codex): handle large sessions and correct skill invocation - #20
Merged
Merged
Conversation
Append Codex session events iteratively so large session arrays do not cross V8's argument limit. Add a 150,000-event regression that checks both merged-session and aggregate counts. Validated with node --test test/session-analysis.test.mjs test/session-analysis-core-facts.test.mjs test/better-harness-evidence-bundle.test.mjs.
Document the host-specific Better Harness invocation for Codex Desktop and Codex CLI in both README languages. Keep slash-command examples for other hosts unchanged and add regression coverage for the Codex sections. Validated with node --test test/session-analysis.test.mjs test/session-analysis-core-facts.test.mjs test/better-harness-evidence-bundle.test.mjs test/better-harness-skill.test.mjs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
RangeError: Maximum call stack size exceeded; Codex users receive host-specific invocation syntax.Traceability and Scope
@better-harnessand Codex CLI examples use$better-harness:better-harnessin English and Simplified Chinese./better-harnessexamples remain unchanged.scripts/session-analysis/platforms/codex.mjs,README.md,README.zh-CN.md, and focused regression tests.SKILL.md, plugin manifests, generic slash-command examples, and release metadata.Change Type
Test and Review Evidence
node --test test/session-analysis.test.mjs test/session-analysis-core-facts.test.mjs test/better-harness-evidence-bundle.test.mjs test/better-harness-skill.test.mjsnpm testnpm run pack:verify$better-harness:better-harnessreturnedBETTER_HARNESS_CLI_SMOKE_OKin an ephemeral read-only taskManual or visual evidence: the Codex Desktop Better Harness skill resolved in the active task; the CLI invocation was exercised with Codex CLI 0.145.0.
Risk and Recovery
6afe786and/or4d14212independently.AI Involvement
Checklist
AGENTS.md,CONTRIBUTING.md, and the relevant canonical-owner guidance.CHANGELOG.md(documentation correction only; out of scope for this PR).