Add workflow metrics endpoint with analytics and tests#158
Closed
Add workflow metrics endpoint with analytics and tests#158
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
GET /api/workflows/{workflow_id}/metricsinserver_api/workflow/router.pywith an in-memory seeding helperseed_workflow_eventsfor deterministic tests.compute_workflow_metricsinserver_api/workflow/metrics.pyto aggregate event type counts, decision metrics (approvals/rejections and rates), stage transition counts, first/last timestamps, and total events while returning safe defaults for empty inputs.server_api/workflow/__init__.pyso it can be mounted by applications.tests/test_workflow_metrics.pyasserting empty-workflow defaults, correctness against seeded events, and a stable response schema for missing workflows.Testing
python -m pytest -q tests/test_workflow_metrics.pywhich completed successfully with3 passed.uv run pytest -q tests/test_workflow_metrics.pybut it failed due to an editable package metadata issue forpytorch_connectomicsin this environment (packaging metadata error); this did not affect the targeted unit tests which passed underpython -m pytest.tests/test_workflow_metrics.pypassed under the working test runner.Codex Task