Add frontend proposal cards for prioritize_failure_hotspots and preview_correction_impact#152
Closed
Add frontend proposal cards for prioritize_failure_hotspots and preview_correction_impact#152
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
prioritize_failure_hotspotsandpreview_correction_impact) as readable cards in the chat timeline.Description
client/src/contexts/workflow/proposalCardConfig.jsthat detectstype/proposal_type, truncates rationale, and selects key fields for each new proposal type.AgentProposalCardcomponent atclient/src/components/chat/AgentProposalCard.jsto render title, compact rationale, key fields and keepApprove/Rejectbuttons.ChatTimelineMessageatclient/src/components/chat/ChatTimelineMessage.jsto renderAgentProposalCardwhenitem.kind === "agent_proposal"and otherwise render normal messages.client/src/__tests__/agentProposalCards.test.jscovering both new proposal types (rendering, rationale truncation) and fallback behavior, and ensure approve/reject callbacks are invoked.testscript toclient/package.jsonto support the required test command.Testing
npm --prefix client test -- --watchAll=false --runInBand agentProposalCardsand the suite passed: 1 test suite, 3 tests passed.npm --prefix client run buildand the production build completed successfully (compiled with unrelated ESLint warnings).Codex Task