Add workflow timeline actor and event-type filters#151
Closed
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WorkflowTimelineProviderthat exposesactorFilter,eventTypeFilter,filteredEvents,setActorFilter,setEventTypeFilter, andclearFiltersand normalizes/filtering logic; filtering is computed withuseMemoto minimize work for long lists (client/src/contexts/workflow/WorkflowTimelineContext.js).WorkflowTimelinethat consumes the provider and renders events as an accessible list, and aWorkflowTimelineFilterscomponent with actor select (all/user/agent/system), event-type text input, and a clear button (client/src/components/workflow/WorkflowTimeline.js,client/src/components/workflow/WorkflowTimelineFilters.js).client/src/__tests__/workflowTimelineFilters.test.jsx).testscript toclient/package.jsonso test commands required by CI/local workflow are available (client/package.json).Testing
npm --prefix client test -- --watchAll=false --runInBand workflowTimelineFiltersand all tests passed (3 passed).npm --prefix client run buildand the production build completed successfully (build succeeded with ESLint warnings reported during compilation).Codex Task