Add actor and event-type filters for workflow timeline#149
Closed
Add actor and event-type filters for workflow timeline#149
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
timelineFilters.jsthat exportsTIMELINE_ACTOR_OPTIONS,DEFAULT_TIMELINE_FILTERS,normalizeTimelineFilters,eventMatchesTimelineFilters, andfilterTimelineEventswith a fast-path when no filters are set.WorkflowTimelineFiltersUI component providing an actor dropdown, an event-type text input, and a clear/reset button that calls the provided callbacks.WorkflowTimelinecontainer component that renders the filter controls and memoizes filtered events usinguseMemoso filtering recomputes only wheneventsorfilterschange.workflowTimelineFilters.test.jsthat cover default full-timeline behavior, actor/text filter combinations, and clear/reset interactions.Testing
npm --prefix client test -- --watchAll=false --runInBand workflowTimelineFiltersfailed because this repository'sclient/package.jsondoes not define atestscript (expected fail).cd client && npx react-scripts test --watchAll=false --runInBand workflowTimelineFilterspassed and reported 3 tests passing for the new suite.npm --prefix client run buildcompleted successfully and produced a production build with warnings only.Codex Task