Backend chat observability upgrade: standardized request summary logs#146
Closed
Backend chat observability upgrade: standardized request summary logs#146
Conversation
Collaborator
Author
|
Consolidated into draft PR #165 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
request_id,endpoint,latency_ms,status, anderror_typewhile preserving existing verbose logs.Description
server_api/chatbot/logging_utils.pyexposingrequest_id_from_requestandlog_request_summarythat emits a standardized one-line summary with the required fields.server_api/main.py(/chat/query,/chat/clear,/chat/status,/chat/helper/query,/chat/helper/clear) capturing start time, status (ok/error), and error type without logging request bodies.agent/chat-observability-upgradeand include a new test filetests/test_chat_logging_fields.py.Testing
tests/test_chat_logging_fields.pywhich asserts presence ofrequest_id,endpoint,latency_ms,status, anderror_typein summary logs and verifies sensitive payload text is not present.uv run pytest -q tests/test_chat_logging_fields.pywhich failed in this environment due to editable dependency metadata forpytorch_connectomics(environment-specific), but the targeted test runPYTHONPATH=. pytest -q tests/test_chat_logging_fields.pyexecuted successfully.tests/test_chat_logging_fields.pypassed (2 passed).Codex Task