[WIP] Sliced OT Plans#767
Open
eloitanguy wants to merge 72 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 96.80% 96.83% +0.02%
==========================================
Files 118 124 +6
Lines 23721 24064 +343
==========================================
+ Hits 22963 23302 +339
- Misses 758 762 +4 🚀 New features to boost your workflow:
|
clbonet
reviewed
Mar 5, 2026
Collaborator
clbonet
left a comment
clbonet
left a comment
There was a problem hiding this comment.
Nice PR @eloitanguy @lchapel!
Here are few comments.
Co-authored-by: Clément Bonet <32179275+clbonet@users.noreply.github.com>
…into dev_sliced_plans
clbonet
reviewed
Jun 1, 2026
Comment on lines
+55
to
+57
| thetas : array-like, shape (n_projections, d), optional | ||
| The projection directions. If None, random directions will be | ||
| generated. |
Collaborator
There was a problem hiding this comment.
For consistency with ot.sliced_wasserstein_distance, use projections and shape (d, n_projections)?
Comment on lines
+230
to
+232
| thetas : array-like, shape (n_projections, d), optional | ||
| The projection directions. If None, random directions will be generated | ||
| Default is None. |
Collaborator
There was a problem hiding this comment.
For consistency with ot.sliced_wasserstein_distance, use projections and shape (d, n_projections)?
Comment on lines
+390
to
+392
| thetas : array-like, optional | ||
| An array-like of shape (n_projections, d) representing the projection directions. | ||
| If None, random directions will be generated. Default is None. |
Collaborator
There was a problem hiding this comment.
For consistency with ot.sliced_wasserstein_distance, use projections and shape (d, n_projections)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Note: this PR continues #757 which was merged by accident.
Implements min-Pivot Sliced Plans Mahey et al., Tanguy et al. and Expected Sliced Plans Liu et al., Tanguy et al., and Generalised Sliced Wasserstein Plans Chapel et al..
Checklist:
RELEASES.mdandREADME.mdtforjax, test accordingly, and add a warning in the docPR checklist