Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3868 +/- ##
==========================================
- Coverage 89.67% 89.60% -0.08%
==========================================
Files 908 908
Lines 106735 106744 +9
==========================================
- Hits 95717 95643 -74
- Misses 11018 11101 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Robbybp
left a comment
There was a problem hiding this comment.
I imagine this is coming up because, on one side, you're saving data with include_named_expressions=True, then later loading that data into the model gives an error?
What do you mean by this?
the model will get messed up because the expression will be replaced
Can you provide an example?
Handling None like this for interpolation makes sense to me.
| if var.ctype == Expression: | ||
| continue |
There was a problem hiding this comment.
Should we silently continue or raise an error? You could imagine calling load_data({"myexpr": 1.0}) then being confused when the value of the expression doesn't change.
Fixes None
Summary/Motivation:
When loading MPC data into a model, if a data key is an
Expression, the model will get messed up because the expression will be replaced. This PR makes loading MPC data into a model ignore expressions.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: