Skip to content

fix(ui): use correct keys when removing views from the store #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmphase wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(ui): use correct keys when removing views from the store #3360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4095c9f
fix(ui): use correct keys when removing views from the store
vmphase Aug 21, 2026
6630a8d
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 21, 2026
3d19393
chore: update changelog
vmphase Aug 21, 2026
7f5f70e
Merge branch 'master' into fix/viewstore-removeitem
Dorukyum Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#3320](https://github.com/Pycord-Development/pycord/pull/3320))
- Fix `SyntaxWarning` about `return` in a `finally` block raised on Python 3.14+
([#3332](https://github.com/Pycord-Development/pycord/pull/3334))
- Fix an issue where stopped views would not be cleaned up.
([#3360](https://github.com/Pycord-Development/pycord/pull/3360))

### Deprecated

Expand Down
11 changes: 6 additions & 5 deletions discord/ui/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,8 @@
from ..components import TextDisplay as TextDisplayComponent
from ..components import Thumbnail as ThumbnailComponent
from ..components import _component_factory
from ..enums import ChannelType, SeparatorSpacingSize
from ..enums import ChannelType
from ..errors import Forbidden, NotFound
from ..utils import find
from .core import ItemInterface
from .item import Item, ItemCallbackType, ModalItem, ViewItem

Expand Down Expand Up @@ -1002,9 +1001,11 @@ def add_view(self, view: BaseView, message_id: int | None = None):
self._synced_message_views[message_id] = view

def remove_view(self, view: BaseView):
for item in view.walk_children():
if item.is_storable():
self._views.pop((item.type.value, item.custom_id), None) # type: ignore
keys_to_remove = [
key for key, (stored_view, _) in self._views.items() if stored_view is view
]
for key in keys_to_remove:
del self._views[key]

for key, value in self._synced_message_views.items():
if value.id == view.id:
Expand Down