Skip to content

fix(modal): use _weights instead of __weights in remove_item() #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmphase wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(modal): use _weights instead of __weights in remove_item() #3357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daab0ef
fix(modal): use _weights instead of __weights in remove_item()
vmphase Aug 20, 2026
6ef3e85
Merge branch 'master' into fix/3356
Dorukyum Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#3320](https://github.com/Pycord-Development/pycord/pull/3320))
- Fix `SyntaxWarning` about `return` in a `finally` block raised on Python 3.14+
([#3332](https://github.com/Pycord-Development/pycord/pull/3334))
- Fixed `AttributeError` when using `Modal.remove_item()`.
([#3357](https://github.com/Pycord-Development/pycord/pull/3357))

### Deprecated

Expand Down
2 changes: 1 addition & 1 deletion discord/ui/modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def remove_item(self, item: InputText) -> Self:

super().remove_item(item)
try:
self.__weights.remove_item(item)
self._weights.remove_item(item)
except ValueError:
pass
return self
Expand Down