fix: 🐛 Primary guild update not firing on_user_update#3077
Merged
Paillat-dev merged 15 commits intoPycord-Development:masterfrom Jan 29, 2026
Merged
fix: 🐛 Primary guild update not firing on_user_update#3077Paillat-dev merged 15 commits intoPycord-Development:masterfrom
on_user_update#3077Paillat-dev merged 15 commits intoPycord-Development:masterfrom
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3077/head:pr-3077
git checkout pr-3077This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3077/head |
on_user_updateon_user_update
Soheab
previously approved these changes
Jan 26, 2026
Paillat-dev
requested changes
Jan 26, 2026
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
Paillat-dev
requested changes
Jan 26, 2026
Member
Paillat-dev
left a comment
There was a problem hiding this comment.
after.primary_guild is not a PrimaryGuild object in my testing but rather just a dictionary
Member
|
Getting the event twice: |
Paillat-dev
requested changes
Jan 28, 2026
Member
Paillat-dev
left a comment
There was a problem hiding this comment.
Tested, works. Mostly nitpick.
Co-authored-by: Paillat-dev <me@paillat.dev>
Paillat-dev
reviewed
Jan 28, 2026
Paillat-dev
requested changes
Jan 28, 2026
Co-authored-by: Paillat-dev <me@paillat.dev>
Paillat-dev
reviewed
Jan 28, 2026
Co-authored-by: Paillat-dev <me@paillat.dev>
Paillat-dev
approved these changes
Jan 28, 2026
Member
Paillat-dev
left a comment
There was a problem hiding this comment.
lgtm; tested; nice pr, thank you !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, an update to a user's primary guild would not fire the
on_user_updateevent. This is now the case. The underlying dict for users was also updated with the missingprimary_guildkeyInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.