fix: pin click<8.2 to prevent CLI crash on startup#302
Open
octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
Open
fix: pin click<8.2 to prevent CLI crash on startup#302octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294
Problem
Running
pyspur init(or any CLI command) fails immediately with:The full traceback ends at
click/core.pyinsideOption.__init__. This is a breaking change introduced in click 8.2.0, which added strict validation that secondary flags (e.g.,--flag/--no-flag) may only be applied to boolean options.typer==0.9.0(currently pinned) generates option definitions that trigger this check when click 8.2+ is installed.The workaround confirmed by users is
pip install "click<8.2", but without an explicit upper bound inpyproject.tomlthe broken version gets pulled in automatically.Solution
Add
"click<8.2"as an explicit dependency constraint. This keepstyper==0.9.0working correctly without requiring an immediate typer upgrade (which would risk larger API-level breaking changes).Testing
pip install "click<8.2"restorespyspur initfunctionality (confirmed by multiple users in the issue thread)