fix: handle enum types correctly in json_schema_to_model#301
Open
octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
Open
fix: handle enum types correctly in json_schema_to_model#301octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
octo-patch wants to merge 1 commit intoPySpur-Dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
Problem
SendEmailNode(and other nodes withhas_fixed_output=Trueand enum fields) throws a Pydantic validation error at runtime:Root cause: When
setup()processesoutput_json_schemafor a node withhas_fixed_output=True, it callsjson_schema_to_model(). That function recursively calls itself on every$defsentry — including enum definitions likeEmailProvider. Because enum schemas have noproperties,json_schema_to_modelcreates an empty Pydantic model for them. Later, whenjson_schema_to_pydantic_typeresolves the$ref, the field type becomes that empty model instead ofstr. Pydantic then rejects the actual enum value with "Input should be a valid dictionary or instance of EmailProvider".Solution
In
json_schema_to_model, before recursively converting a$defsentry, check whether the definition contains an"enum"field. If it does, map it to the appropriate Python primitive type (str,int,float,bool) instead of creating a Pydantic model. This correctly handles all JSON Schema enum types that reference a primitive base type.Testing
Manually traced the code path for
SendEmailNodeOutput.model_json_schema():EmailProviderdefinition ({"enum": ["resend", "sendgrid"], "type": "string"}) now maps tostrindefsproviderfield resolves tostr, accepting both enum instances and raw string valuesjson_schema_to_modelas before