feat: likelihood breakpointer #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxPastukhov15
changed the title
MaxPastukhov15
changed the title
iraedeus
requested changes
Dec 4, 2025
| absolute difference between the current and previous log-likelihood values | ||
| falls below a specified threshold: | ||
|
|
||
| |L_{t+1} - L_t| < threshold |
There was a problem hiding this comment.
Put math experessions in docstrings with ..math::
| def __init__(self, threshold: float): | ||
| self._validate(threshold) | ||
| self.threshold = threshold | ||
| self._L_old: Optional[float] = None |
There was a problem hiding this comment.
Why two variables? It is enough to have 1 variable _likelihood_old
And do not use capital letters in mutable variables
…n init instead of two
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements and tests the LikelihoodBreakpointer, which stops the EM-like iterative pipeline when the change in log-likelihood between consecutive iterations falls below a specified threshold (|L_{t+1} - L_t| < threshold).
Key changes:
Added LikelihoodBreakpointer class with proper convergence logic and validation.
Wrote unit tests using mocked likelihood sequences to reliably verify convergence detection, first-call behavior, and instance reuse after reset.
Closes #52