No std ThreadId#6056
Conversation
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, one comment on the FFI definition (see below).
Do you expect that the test suite (which does a lot of thread spawning) will need to change?
I don't think it will need to change, but it might be worth enabling it for wasm build and pulling in one of the wasm threading crates as a dev dependency. |
2f2eb80 to
513cc78
Compare
Merging this PR will improve performance by 10.89%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | ordered_dunder_methods |
2.7 µs | 2.4 µs | +10.89% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Person-93:no_std_thread_id (bd36107) with main (7550783)
|
@codspeedbot explain why this is faster |
|
Should we exclude PyPy from |
def302d to
bd36107
Compare
Re-implement
ThreadIdusingPyThread_get_thread_ident. This makes is usable inno_stdcontext.