Add Py_SET_SIZE and Py_RETURN_NOTIMPLEMENTED functions#6003
Open
Add Py_SET_SIZE and Py_RETURN_NOTIMPLEMENTED functions#6003
Conversation
Member
|
Hi -- you are sending a ton of these PRs adding new bindings. Can you explain what your motivation/goals are? It's very hard for us to tell if these add any value, or they're just being added for completeness. |
davidhewitt
reviewed
Apr 29, 2026
| (Py_TYPE(ob) == tp) as c_int | ||
| } | ||
|
|
||
| // skipped Py_SET_TYPE |
Member
There was a problem hiding this comment.
Should include Py_SET_TYPE for non-limited API operations?
|
|
||
| // skipped Py_RETURN_NONE | ||
| #[inline] | ||
| pub unsafe fn Py_RETURN_NONE() -> *mut PyObject { |
Member
There was a problem hiding this comment.
This is a macro which doesn't make sense to expose for the same reason #5976 was closed.
|
|
||
| // skipped Py_RETURN_NOTIMPLEMENTED | ||
| #[inline] | ||
| pub unsafe fn Py_RETURN_NOTIMPLEMENTED() -> *mut PyObject { |
Member
There was a problem hiding this comment.
Same comment that this doesn't work like the C macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.