-
Notifications
You must be signed in to change notification settings - Fork 960
add PythonABI and new builder structs for pyo3-build-config InterpreterConfig #5924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ngoldbaum
wants to merge
20
commits into
PyO3:main
Choose a base branch
from
ngoldbaum:abi-tag-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c8e40b9
add CPythonABI enum for pyo3-build-config InterpreterConfig
ngoldbaum 45d5cc1
add release note
ngoldbaum e3dc133
store ABI details in a new PythonAbi struct
ngoldbaum 966a82f
fix nox config file
ngoldbaum 9d9a0e2
fix ffi-check
ngoldbaum f52f1d8
Refactor to use the builder pattern for InterpreterConfig
ngoldbaum 77039d2
revert noxfile change
ngoldbaum 0765953
fix clippy-all
ngoldbaum cde688c
fix build-config test
ngoldbaum b11b262
Fix issues linking against onld stable ABI versions
ngoldbaum 9cb420a
remove load-bearing debug impls
ngoldbaum 7fe98ab
fix issue with InterpreterConfig::from_interpreter never returning an…
ngoldbaum 41be837
fix clippy lint
ngoldbaum 58162a4
fix PythonAbiBuilder::from_build_env
ngoldbaum 48a7d20
Only target abi3 for non-free-threaded builds
ngoldbaum c899390
fix logic error in InterpreterConfig::from_reader
ngoldbaum ea2eab7
Add stub abi3t implementation
ngoldbaum 8354ef7
Improve test coverage
ngoldbaum 6854756
fix clippy
ngoldbaum 3a21665
fix 3.14t abi3 builds being a no-op
ngoldbaum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| The boolean abi3 field of pyo3_build_config::impl_::InterpreterConfig is now a | ||
| variant of a new CPythonABI enum. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is out of date now and needs to be updated