Repository navigation
Visualizer3D: a turned deck has the track marks it has upright - #1629
Open
sriramdevadas wants to merge 1 commit into
Open
sriramdevadas wants to merge 1 commit into
sriramdevadas wants to merge 1 commit into
Conversation
`describe_grid` measures how far a deck's marks run along the deck's own y axis, the frame the page draws them in: the deck's own depth, and the depth of each carrier seated on the track line, turned as it stands on the deck. Turning the deck turns its marks without changing their length.
Contributor
Author
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
On
main,describe_gridgives the page a deck's track grid in the deck's own frame, wheremarks.jsdraws it, but takes the marks' length fromget_absolute_size_y(), the depth of the deck's box in the world, and measures a seated carrier the same way. A STARlet turned 90 degrees ends its marks 1005 mm back on a deck 653.5 mm deep, and 198 mm back beside a carrier that reaches 560 mm.PR Content
describe_gridmeasures both in the deck's own frame: the deck withget_size_y(), a seated carrier from its corners withget_location_wrt.Tests:
grids_tests.pyturns a STARlet 90 and 37.5 degrees, bare and with a carrier, and checks it keeps its upright grid. All four cases fail onmain. Compared withmain, upright grids of the STAR-family, Vantage and Nimbus decks are unchanged.make test,make lint,make format-checkandmake typecheckpass on Linux, and Unit Tests passes on my fork, 18 of 18 jobs (run).Before and after, two turned STARlets from above:
🤖 Generated with Claude Code