Repository navigation
feat: add album art URL variable - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
system_media_album_art_url, the address of the current cover, so a widget built with the Custom Button plugin can show the album art like the Music Player widget does. Asked for on Discord by the Custom Button author, as WebNowPlaying already offers one./api/music-player/artwork/art-8afec4c090bbd648?instanceId=com.pyflat.system-media%3A%3Acurrent. The host fetches the image throughGetArtworkAsync, which already serves the widget, so local files and thumbnails without a URL work too. Built the same way as the host's WebNowPlaying and Spotify integrations.<plugin id>::<instance id>. The plugin id comes fromPluginMetadataat runtime, so it stays inmanifest.jsononly.system_media_spotify_album_art_url, shown as "Spotify: Album art URL".@app variant escaped;Checklist
make buildandmake testpass locally (0 warnings, 261 tests; 278 with-p:SystemMediaWindows=false).make conformancepasses (32 passed, 0 failed; MDC0802 is inconclusive, as onmain).Tested on
Macro Deck 3 host, Windows 11, with Custom Button 0.48.6:
system_media_album_art_url,system_media_track_nameandsystem_media_artistshows the cover, title and artist;