fix: BMP save/load uses BI_BITFIELDS for correct RGB565 color encoding - #16
Merged
Merged
Conversation
…annel corruption Co-authored-by: bdbarnett <127794626+bdbarnett@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix graphics.save_image() mis-encoding of mixed RGB565 colors to BMP
fix: BMP save/load uses BI_BITFIELDS for correct RGB565 color encoding
Aug 4, 2026
bdbarnett
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_image()wrote RGB565 BMP files withBI_RGBcompression (0), causing standard viewers (Pillow, Windows, etc.) to assume RGB555 layout and corrupt the green channel for any mixed-color pixel.Root cause
BITMAPINFOHEADERwith 16bpp andBI_RGBis underspecified — readers default to 5-5-5. Correct RGB565 requiresBI_BITFIELDS(compression=3) with explicit channel masks.Changes
lib/pygraphics/_bmp565.py— writer: Changed compression field fromBI_RGB(0) →BI_BITFIELDS(3); appends three 4-byte masks (R=0xF800,G=0x07E0,B=0x001F) after theBITMAPINFOHEADER. Data offset updated 54 → 66 bytes.lib/pygraphics/_bmp565.py— reader:read_bmp565_headernow reads and validates the compression field, accepting bothBI_RGB(0) andBI_BITFIELDS(3) for backward compatibility.src/gfx_bmp565.c— writer/reader: Same fixes mirrored in the C implementation.Before / After