Repository navigation
usb-restart accepts an ESP32-S3 in ROM download mode - #126
Merged
Merged
Conversation
A chip in ROM download mode has no USB serial number, so Windows names its node after the chip's MAC address, colons included (USB\VID_303A&PID_0009\ 48:27:E2:E9:B0:10). The allow rule refused it. The serial's character class now admits ':' in both the CLI and the task script; everything else stays as strict: one device per run, parent node only, no wildcards or other characters. The installer self-checks the new shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpftp usb-restart --instancerefused the node of an ESP32-S3 sitting in ROM download mode, because Windows names it after the chip's MAC address with colons:USB\VID_303A&PID_0009\48:27:E2:E9:B0:10.The serial's character class now admits
:inespusb.pyand inrestart-esp-usb.ps1. Nothing else loosens: still one device per run, the parent node only, no&MI_children, no wildcards, and no*,?, spaces, quotes or backslashes in the serial.Tests: the colon id passes in Python and in the PowerShell dry-run (exit 4, no such device); colon ids carrying an
&MI_child, a wildcard, a command, quotes or a second device are still refused. Both new acceptance tests fail on the previous rule.The installer gets a self-check line for the colon shape, and the agent guide says ROM download mode is covered. The installed task script is a copy, so a machine that installed it earlier needs the installer run again before a colon id works.