Repository navigation
Release PR carries every version declaration - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Prepare release workflow opened PRs that moved only VERSION and CHANGELOG.md, so their Tests failed the version check until someone ran scripts/check_versions.py --write on the release branch by hand.
A second job, sync-versions, now follows the shared workflow: it finds the release branch, runs check_versions.py --write, and pushes one commit with the App token (so the PR's Tests run again on it). The shared workflow offers no hook for extra commands, so this stays in mpftp. docs/publishing.md drops the manual step.