Repository navigation
Workspace builds take the library's pinned outside packages from sibling checkouts - #167
Merged
Merged
Conversation
…sibling checkouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a workspace, every module already comes from its sibling checkout instead of its modules.lock pin, but the packages the library pins by tag in lib-lock.json (audioinstruments, audioeffects, pygraphics) were still cloned at the tag. So a workspace build froze audioinstruments 0.4.0, which predates the SoundFont sampler, while the sibling checkout had it.
The library build now passes
--source NAME=CHECKOUTto libbuild.py for each pinned package whose repository has a sibling checkout withlib/NAME, and says so in the build log. Outside a workspace nothing changes: the pinned tags are used.