Skip to content

CPython: a struct is the holder of its callback dict; timers and animations release it #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdbarnett merged 2 commits into from
Oct 12, 2026
Merged

CPython: a struct is the holder of its callback dict; timers and animations release it #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b68c6b1
CPython: a struct is the holder of its callback dict; timers and anim…
bdbarnett Oct 12, 2026
fb64ee5
CI: build the CPython leg against lvgl-python a701ef0, which has the …
bdbarnett Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linux-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
uses: actions/checkout@v7
with:
repository: PyDevices/lvgl-python
ref: 4bc903ce98b5c2862e56e6bf2c4a38b85b09d58e
ref: a701ef0499e9e81e41f9f0cda8d3037156f8f47f
path: lvgl-python
submodules: recursive

Expand Down
17 changes: 15 additions & 2 deletions binding/emit_cpython_native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,13 @@ def try_generate_struct_cpython(struct_name, struct):
decl, "Missing 'user_data' member in struct '%s'" % struct_name
)
write_cases.append(
'if (strcmp(attr, "{field}") == 0) {{ data->{decl_name} = {cast}mp_lv_callback(value, {lv_callback}, "{struct_name}_{field}", {user_data}, NULL, NULL, NULL); result = 0; }}'.format(
'if (strcmp(attr, "{field}") == 0) {{ data->{decl_name} = {cast}mp_lv_callback(value, {lv_callback}, "{struct_name}_{field}", {user_data}, {holder}, NULL, NULL); result = 0; }}'.format(
struct_name=struct_name,
field=sanitize(decl.name),
decl_name=decl.name,
lv_callback=lv_callback,
user_data=full_user_data_ptr,
holder="data" if full_user_data_ptr.startswith("&data->") else "NULL",
cast=cast,
)
)
Expand Down Expand Up @@ -860,6 +861,9 @@ def build_py_callback_arg(arg, index, func, py_var):
else:
if user_data:
full_user_data = "&%s->%s" % (first_arg.name, user_data)
# The struct holds the dict: every callback set on it
# shares one reference, released with the struct.
containing_struct = first_arg.name
elif user_data_getter_fn and user_data_setter_fn:
full_user_data = "NULL"
containing_struct = first_arg.name
Expand Down Expand Up @@ -1222,7 +1226,16 @@ def _arg_sort_key(index, param):
pre_lv_call = ""
post_lv_call = ""
fname = func.name
if fname.endswith("_remove_event_cb_with_user_data"):
# A timer or a started animation holds its callback dict through LVGL's
# ext_data free_cb (lvpy_runtime.c): LVGL releases it on every path that
# frees the timer or the animation copy.
if fname == "lv_timer_create":
post_lv_call = " lvpy_timer_bind(_res);"
elif fname == "lv_timer_set_cb":
post_lv_call = " lvpy_timer_bind(timer);"
elif fname == "lv_anim_start":
post_lv_call = " lvpy_anim_bind(_res);"
elif fname.endswith("_remove_event_cb_with_user_data"):
post_lv_call = " if (_res > 0) lvpy_release_callback_user_data(user_data);"
elif fname == "lv_obj_remove_event_cb":
pre_lv_call = (
Expand Down
Loading
Loading