Repository navigation
audiograph: Graph.get converts its float to mp_float_t, so double-float builds compile - #308
Merged
Merged
Conversation
…at builds compile On a build where mp_float_t is double (the webassembly port), passing a float to mp_obj_new_float is an implicit promotion, and the build's -Werror=double-promotion refuses it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a MicroPython build where
mp_float_tisdouble, such as the webassembly port,Graph.getpasses afloattomp_obj_new_float, and the build refuses the implicit promotion:The value is now cast to
mp_float_texplicitly. It's the only such call in audiograph: the twomp_obj_get_floatreads already cast down tofloat. With this change the webassembly interpreter builds, andimport audiographworks under node. Single-float ports compile the same code as before.