Repository navigation
audiograph on CircuitPython: fix the -Werror=cast-align build break on ESP32 - #305
Merged
Merged
Conversation
… int16 pointer CircuitPython's ESP32 builds compile with -Werror=cast-align, and the cast from a byte pointer to int16_t * stopped the build. The offset is a whole number of int16 blocks into an int16 buffer, so the pointer is aligned; the cast now says so. Nothing else changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircuitPython's ESP32 builds compile with
-Werror=cast-align, andGraph.run's output pointer (a byte pointer cast toint16_t *) stopped the build atshared-bindings/audiograph/Graph.c:251. The offset is a whole number of int16 blocks into an int16 buffer, so it is aligned; the cast now goes throughvoid *to say so. Behaviour is unchanged.Checked by building CircuitPython for the Waveshare ESP32-S3-Touch-LCD-7 with this glue: the unfixed line fails with that error (and it is the only one across the glue, built with
make -k); with the fix the build links. The audiograph tests, the CPython/MicroPython/CircuitPython render comparison at 0 counts and the planted-fault runs all pass.