Skip to content

Render every speaker for co-hosted keynote sessions #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 1 commit into from
Apr 18, 2026
Merged

Render every speaker for co-hosted keynote sessions #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/app/pages/session-detail/session-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ <h1 class="session-title">{{session.name}}</h1>
</div>

<div class="session-body">
<div *ngIf="keynoteData" class="keynote-speaker-card">
<img [src]="keynoteData.photo" [alt]="keynoteData.name" class="keynote-photo">
<div *ngFor="let keynote of keynoteData" class="keynote-speaker-card">
<img [src]="keynote.photo" [alt]="keynote.name" class="keynote-photo">
<div class="keynote-info">
<h3>{{keynoteData.name}}</h3>
<p>{{keynoteData.bio}}</p>
<h3>{{keynote.name}}</h3>
<p>{{keynote.bio}}</p>
</div>
</div>

Expand Down
17 changes: 8 additions & 9 deletions src/app/pages/session-detail/session-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class SessionDetailPage {
isFavorite = false;
isOpenSpace = false;
isKeynote = false;
keynoteData: any = null;
keynoteData: any[] = [];
defaultHref = '';

private keynoteSpeakers: Record<string, any> = {
Expand Down Expand Up @@ -63,15 +63,14 @@ export class SessionDetailPage {
this.isOpenSpace = this.session?.tracks?.includes('open-space');
this.isKeynote = this.session?.tracks?.includes('keynote') || this.session?.track === 'Keynote';

// Enrich keynote sessions with speaker photo/bio
// Enrich keynote sessions with speaker photo/bio. Collect every
// matching speaker so co-hosted keynotes (e.g. "Rachell Calhoun &
// Tim Schilling") render all speakers, not just the first match.
if (this.isKeynote) {
const sessionName = this.session?.name || '';
for (const [name, data] of Object.entries(this.keynoteSpeakers)) {
if (sessionName.toLowerCase().includes(name.toLowerCase())) {
this.keynoteData = { name, ...data };
break;
}
}
const sessionName = (this.session?.name || '').toLowerCase();
this.keynoteData = Object.entries(this.keynoteSpeakers)
.filter(([name]) => sessionName.includes(name.toLowerCase()))
.map(([name, data]) => ({ name, ...data }));
}

this.isFavorite = this.userProvider.hasFavorite(
Expand Down
Loading