E721: Fix false negative for reversed type comparisons (e.g. int == type(obj))

[fazalpsinfo-cmyk]

Summary

Fixes #1187.

The E721 check was missing reversed comparisons where type() appears on the right side of the comparison operator. For example, int == type(obj) was not flagged even though it's equivalent to type(obj) == int.

Root Cause

The COMPARE_TYPE_REGEX has two alternatives — one for type() == X and one for X == type(). The bypass logic that allowed comparing types with == when the inner argument was an identifier only worked correctly when type() was on the left. When type() was on the right, the bypass logic incorrectly used the captured identifier as the comparison value.

Change

• Removed the bypass logic from comparison_type() that allowed type(foo) == type(bar) to pass without an E721 warning. Per PEP 8, comparing types directly with == should always use isinstance().
• This fix also correctly handles type(None) == type(False) style comparisons that were previously allowed.

---

If you found this useful, consider buying me a coffee