Skip to content

Fix rendered evaluator frame transitions #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valtterivalo wants to merge 2 commits into
base: 5.0
Choose a base branch
from
+21 −0
Open

Fix rendered evaluator frame transitions #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a60d48
Fix rendered evaluator frame transitions
valtterivalo Aug 20, 2026
8b56833
Keep evaluator fix display agnostic
valtterivalo Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ocean/osrs/osrs_puffer_render.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

typedef struct {
OsrsEnv env;
int has_drawn;
int last_tick;
} OsrsPufferRenderer;

void* osrs_puffer_render_create(
Expand All @@ -21,14 +23,31 @@ void* osrs_puffer_render_create(
renderer->env.encounter_def = def;
renderer->env.encounter_state = encounter_state;
renderer->env.encounter_context = encounter_context;
renderer->env.tick = def->get_tick(encounter_state, encounter_context);
renderer->last_tick = renderer->env.tick;
visual_load_encounter_collision_map(def, &renderer->env, def->name);
visual_init_render_scene(&renderer->env, def->name, NULL);
return renderer;
}

void osrs_puffer_render_draw(void* opaque_renderer) {
OsrsPufferRenderer* renderer = (OsrsPufferRenderer*)opaque_renderer;
const EncounterDef* def = (const EncounterDef*)renderer->env.encounter_def;
int tick = def->get_tick(
renderer->env.encounter_state,
renderer->env.encounter_context);
renderer->env.tick = tick;
if (renderer->has_drawn) {
RenderClient* render_client = (RenderClient*)renderer->env.client;
if (tick < renderer->last_tick) {
render_reset_episode_visual_state(render_client, &renderer->env);
} else {
render_post_tick(render_client, &renderer->env);
}
}
pvp_render(&renderer->env);
renderer->has_drawn = 1;
renderer->last_tick = tick;
}

void osrs_puffer_render_destroy(void* opaque_renderer) {
Expand Down
2 changes: 2 additions & 0 deletions tests/test_osrs_puffer_render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def test_puf_render_owns_renderer_lifecycle(tmp_path: Path, wrapper: str) -> Non
subprocess.run(
[
compiler,
"-D_POSIX_C_SOURCE=200809L",
"-std=c11",
"-I",
str(REPOSITORY_ROOT),
Expand All @@ -100,3 +101,4 @@ def test_puf_render_owns_renderer_lifecycle(tmp_path: Path, wrapper: str) -> Non
cwd=REPOSITORY_ROOT,
)
subprocess.run([executable], check=True, cwd=REPOSITORY_ROOT)

Loading