Make DEBUG=1 builds work + add DEBUG Torch error catching #482
+67
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make DEBUG=1 builds work. Adds Torch error catching (to DEBUG mode).
Looks like this:
This is particularly important for the individual threads whose exceptions won't be caught by the Python main thread catch-all.
To build the DEBUG version:
DEBUG=1 python setup.py build_torch --force --inplace && DEBUG=1 python setup.py build_breakout --force --inplace(TODO: Must add back NO_ASAN=1 too once ASAN is impl'ed)