Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 504cf430f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| WiFi.mode(WIFI_STA); | ||
| delay(100); | ||
| Serial.println(F("[boot] WiFi init... OK")); |
There was a problem hiding this comment.
Gate WiFi init success log on actual init result
The new boot status line always prints "[boot] WiFi init... OK" even if WiFi.mode(WIFI_STA) fails, which can mask real radio/init failures during factory bring-up and make later MAC/Wi-Fi test failures harder to diagnose. In this setup path, the success message should be conditioned on the WiFi.mode(...) return value (or equivalent error check) so the log reflects the true boot state.
Useful? React with 👍 / 👎.
Links
What & Why
WiFi.macAddress()was returning00:00:00:00:00:00in the splash because the WiFi driver wasn't initialized yetWiFi.mode(WIFI_STA)+delay(100)insetup()before the splash prints, then immediately set back toWIFI_OFF[boot]status lines for LittleFS and WiFi init so operator knows board is alive during startupsplashserial()for device traceabilityValidation / How to Verify
[boot] LittleFS... OKand[boot] WiFi init... OKappear on startupMAC (STA):in the splash shows a real MAC address (not00:00:00:00:00:00)Artifacts (attach if relevant)
Checklist