feat: add ImgEdit benchmark with edit type subsets#517
Merged
davidberenstein1957 merged 16 commits intofeat/add-partiprompts-benchmark-to-prunafrom Feb 27, 2026
Merged
Conversation
Closes #510 - Add setup_imgedit_dataset in datasets/prompt.py - Support subset filter (replace, add, remove, adjust, extract, style, background, compose) - Fetch instructions and judge prompts from GitHub (PKU-YuanGroup/ImgEdit) - Register ImgEdit in base_datasets - Add BenchmarkInfo entry with accuracy metric, task_type image_edit - Add test for loading with subset filter Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
…nting - Rename subset parameter to category in setup_imgedit_dataset - Add empty dataset guard before ds.select([0]) - Fix trailing newlines linting issue - Update tests to use category parameter Co-authored-by: Cursor <cursoragent@cursor.com>
Prevents crash when category filter produces empty dataset. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This PR has been inactive for 10 days and is now marked as stale. |
…mgedit-benchmark Made-with: Cursor
…hmark pattern - Resolve conflicts in prompt.py and test_datamodule.py - Refactor setup_imgedit_dataset: ImgEditCategory, fraction, test_sample_size, _prepare_test_only_prompt_dataset - Add ImgEdit to BENCHMARK_CATEGORY_CONFIG Made-with: Cursor
7e59c76 to
ce71981
Compare
Made-with: Cursor
… script Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
src/pruna/data/__init__.py
Outdated
| name="imgedit", | ||
| display_name="ImgEdit", | ||
| description="Image editing benchmark with 8 edit types for evaluating editing capabilities.", | ||
| metrics=["accuracy"], |
Member
Author
There was a problem hiding this comment.
should be img_edit_score but is not implemented in pruna
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ep ImgEdit and GenEval Made-with: Cursor
3be835c to
7ebb4cd
Compare
…ep ImgEdit, HPS, LongTextBench, GenEval Made-with: Cursor
…ep ImgEdit and GenEval Made-with: Cursor
be60209
into
feat/add-partiprompts-benchmark-to-pruna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
Summary
Usage
Test plan
PrunaDataModule.from_string("ImgEdit")works