Open
Conversation
simlang
approved these changes
Jan 19, 2026
Member
simlang
left a comment
There was a problem hiding this comment.
looks good! Thanks for taking care of that, super useful for literally everything 🚀
Just had a question about the backward compatibility
4bcb4cd to
87a422d
Compare
|
This PR has been inactive for 10 days and is now marked as stale. |
7a275fa to
88821bb
Compare
gsprochette
commented
Feb 5, 2026
| smash_config = SmashConfig() | ||
| smash_config.load_from_json(model_path) | ||
| if "torch_artifacts" in smash_config.load_fns: | ||
| _convert_to_artifact(smash_config, model_path) |
Collaborator
Author
There was a problem hiding this comment.
@simlang in response to your comment I removed the logic in save.py and added this function:
- update both the save and load fns
- save the smash config so that it's fixed for when we remove this logic in a future version after some deprecation time
- log a warning saying it was updated and asking to warn any remote provider (because those would never receive the warning nor have the update automatically saved)
Let me know if that's to your liking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Formalize artifact saving and expose it to more algorithms, and add artifact hooks into Smash config
Type of Change
How Has This Been Tested?
Checklist
Additional Notes