Repository navigation
Prepare packages for npm publishing under @promact scope - #6
Merged
Merged
Conversation
- Rename packages to @promact/email-service, @promact/file-service, @promact/feature-flag-management - Remove private flag, add license, repository and publishConfig - Add publish workflow triggered on GitHub Release - Document installation and release process in README Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ll steps for all packages Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@promact/email-service,@promact/file-service,@promact/feature-flag-management(the unscoped nameemail-serviceis already taken on npm by an unrelated package)."private": truefrom the three packages (the root stays private) and addslicense: MIT,repository,homepage,bugs,publishConfig.access: public..github/workflows/publish.yml: runs on a published GitHub Release (or manually), builds/lints/tests, then publishes each package via npm trusted publishing (OIDC, no stored token), skipping versions already on npm.file-serviceandfeature-flag-management, plus install instructions for all packages and a release section in the root README.Testing
npm run build,npm run lint,npm test: 79/79 passing.npm publish --workspaces --dry-run: all three resolve to@promact/*, public access.npm pack) and installed them into a fresh sample consumer project:.d.tsfiles passes; CJSrequireand ESM named imports both work.getKeys, delete,FileNotFoundErroron a missing blob. The S3 provider has no configurable endpoint, so only its config and model validation was exercised.Authorizationheader, subscription constraint Pro → true / default Basic → false); LaunchDarkly in offline mode → false.Before merging / releasing
promactorg exists on npmjs.com and the publisher has accessnpm login→npm run build && npm publish --workspaces)@promact/*package (repoPromact/reusable-components-node, workflowpublish.yml)🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.