Skip to content

Prepare packages for npm publishing under @promact scope - #6

Merged
roshni-shah-promact merged 3 commits into
masterfrom
chore/npm-publish-setup
Oct 5, 2026
Merged

roshni-shah-promact merged 3 commits into
masterfrom
chore/npm-publish-setup

Conversation

@roshni-shah-promact

@roshni-shah-promact roshni-shah-promact commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Renames packages to @promact/email-service, @promact/file-service, @promact/feature-flag-management (the unscoped name email-service is already taken on npm by an unrelated package).
  • Removes "private": true from the three packages (the root stays private) and adds license: MIT, repository, homepage, bugs, publishConfig.access: public.
  • Adds .github/workflows/publish.yml: runs on a published GitHub Release (or manually), builds/lints/tests, then publishes each package via npm trusted publishing (OIDC, no stored token), skipping versions already on npm.
  • Adds READMEs for file-service and feature-flag-management, plus install instructions for all packages and a release section in the root README.

Testing

  • npm run build, npm run lint, npm test: 79/79 passing.
  • npm publish --workspaces --dry-run: all three resolve to @promact/*, public access.
  • Packed the tarballs (npm pack) and installed them into a fresh sample consumer project:
    • TypeScript strict typecheck against the shipped .d.ts files passes; CJS require and ESM named imports both work.
    • email-service: SMTP send against a local SMTP server (STARTTLS + auth) delivered with the correct From, Subject, HTML body and no empty Cc.
    • file-service: Azure provider against Azurite: upload, exists, download, working SAS URL, paginated getKeys, delete, FileNotFoundError on a missing blob. The S3 provider has no configurable endpoint, so only its config and model validation was exercised.
    • feature-flag-management: PostHog against a local HTTP fake (active/inactive/unknown/unreachable, path and Bearer auth); Unleash's real SDK against a local fake server (enabled/unknown flags, raw Authorization header, subscription constraint Pro → true / default Basic → false); LaunchDarkly in offline mode → false.

Before merging / releasing

  • promact org exists on npmjs.com and the publisher has access
  • First version published manually (npm login → npm run build && npm publish --workspaces)
  • Trusted Publisher configured on each @promact/* package (repo Promact/reusable-components-node, workflow publish.yml)
  • Future releases: bump versions, then create a GitHub Release

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

roshni-shah-23 and others added 2 commits October 5, 2026 11:59
- Rename packages to @promact/email-service, @promact/file-service,
  @promact/feature-flag-management
- Remove private flag, add license, repository and publishConfig
- Add publish workflow triggered on GitHub Release
- Document installation and release process in README

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ll steps for all packages

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b80c3dff-72f1-457b-85ce-3a5c7bc9a833
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@roshni-shah-promact
roshni-shah-promact merged commit 30c7355 into master Oct 5, 2026
2 checks passed
@roshni-shah-promact
roshni-shah-promact deleted the chore/npm-publish-setup branch October 5, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants