Conversation
Emit stable error_code on Event logs, add ErrorCode/WarnCode helpers, and scrub secret field values before context is written.
Route schema/SQL/outbox/side-effect failures through Event/WarnCode, reuse ScrubMap for audit and sensitive SQL args, and drop applog.L.
Use WarnCode for SYNC_PARTIAL/XML_LINK_FAILED and cron failure paths, and replace unstructured scheduler.L cron start logs with Events.
Stop logging failures via WebLogf success status; classify record and access errors with errcode at shared web choke points.
Redact secret fields before printing records, validate Atoi input, and send errors to stderr.
Align the Logging section with the structured error_code contract.
Align local lint with CI so make check does not run SWC twice.
Move shared stage colors into sumeru-theme and drop duplicate hardcoded stage values from shell/workspace/views stylesheets.
Log or return information_schema and seed failures, honor XML link errors during data sync, and fail bulk cancel when CancelBatch errors.
Keep only the record id; pass request context separately to handlers.
Stop empty catch blocks in shell storage, bus, RPC, and map helpers so client-side failures are visible during development.
Share ClassifyLogCode across ORM/web, drop logORMOperationKV and double-logs, and slim SQL debug wrappers without changing the ErrorCode/WarnCode contract.
refactor(logging): collapse classifiers and Event boilerplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote stable
devtomain:Test plan
devdev_mode, CSRF secret set)