Repository navigation
fix(asap-tools): probe the ClickHouse adapter's readiness endpoint - #905
Open
milindsrivastava1997 wants to merge 1 commit into
Open
milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
A ClickHouse-backed query engine serves /clickhouse/ping and no Prometheus API, so the readiness check on /api/v1/status/runtimeinfo never passed and every ClickHouse sketchdb run timed out after 60 s. The endpoint now follows the backend type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
QueryEngineRustServicechecks readiness by curling/api/v1/status/runtimeinfo, the Prometheus adapter's endpoint. A ClickHouse-backed engine serves/clickhouse/pinginstead (clickhouse_http.rs:178) and returns 404 on the Prometheus path, sowait_until_readytimed out after 60 s on every ClickHouse sketchdb run. Seen on CloudLab while testing #874: the engine was up (/clickhouse/ping200,/api/v1/status/runtimeinfo404).Fix:
runtime_info_endpoint(backend_type)picks the adapter's endpoint;start()stores it and the readiness check probes it.Tests:
tests/test_victoriametrics_readiness.py.🤖 Generated with Claude Code