feat(skills): add code-design-review and test-coverage-review skills - #543
Open
milindsrivastava1997 wants to merge 2 commits into
Open
feat(skills): add code-design-review and test-coverage-review skills#543milindsrivastava1997 wants to merge 2 commits into
milindsrivastava1997 wants to merge 2 commits into
Conversation
Codify recurring PR review guidance (fail loud, no magic numbers, precise naming, no half-built abstractions, negative-path test coverage) as Claude Code skills, plus a CLAUDE.md with PR-hygiene process notes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
milindsrivastava1997
marked this pull request as ready for review
August 18, 2026 15:09
…ostic Move canonical checklist content to .agents/skills/*.md and add AGENTS.md so non-Claude agents can read them too. .claude/skills/*/SKILL.md keep their frontmatter for Claude Code's auto-discovery but now just point at the shared files; CLAUDE.md points at AGENTS.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
I'd like to suggest adding a new skill: a checklist for adding a new SQL capability. Supporting one new SQL shape, whether that's a new aggregation, a new clause, or a new sketch backing, is a chain that runs across four crates: the parser in sql_utilities, capability declaration in asap_types, config generation in asap-planner-rs, and execution plus accumulators in asap-query-engine. Would this be the right place to add this skill? |
Contributor
|
The skills in this PR look good to me. |
akanksha-akkihal
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-design-reviewandtest-coverage-reviewClaude Code skills under.claude/skills/, codifying recurring PR review guidance: fail loud instead of silently defaulting, no magic numbers / scattered config defaults, precise naming (including units), no half-built abstractions or duplicated logic, and negative-path test coverage.CLAUDE.mdwith PR-hygiene process notes (keep PRs small/single-purpose, PR titles follow Conventional Commits) and pointers to the two skills.