refactor!: move AccuracyModel and evidence to plan-selection; let the model accept outputs regardless of guarantee

crates/devtools/src/bin/stage_pipeline.rs

@@ -31,10 +31,14 @@
 //   - stage3_plan_selection: the selected candidate, chosen among all candidates;
 //     the shown candidates' costs and accepted accuracy (per query: the
 //     target's metric or null when not set, the accepted guarantee's
-//     metric or null when exact, the sketches read and a one-line
+//     metric or null when exact or accepted regardless of guarantee,
+//     whether the deployment's accuracy model accepted it directly,
+//     whatever its guarantee says (`accepted_regardless_of_guarantee`),
+//     the sketches read and a one-line
 //     summary), and every other shown candidate under `rejected` with
 //     its `cause`: a failed check (`failure_probability_resize_failed`,
-//     `accuracy_target_missed`, `raw_data_not_retained`,
+//     `accuracy_target_missed`, `count_min_weights_not_proven_non_negative`,
+//     `no_accuracy_guarantee`, `raw_data_not_retained`,
 //     `latency_bound_exceeded`, `over_cluster_capacity`) or a loss under
 //     the cost model (`costlier`, `slower`, `more_memory`,
 //     `not_lowest_latency_on_pareto_front`, `dominated`,
@@ -617,6 +621,7 @@ fn plan_selection_json(
                     json!({
                         "target_metric": accepted.target_metric,
                         "accepted_metric": accepted.accepted_metric,
+                        "accepted_regardless_of_guarantee": accepted.accepted_regardless_of_guarantee,
                         "sketches": accepted.sketches,
                         "summary": accepted.to_string(),
                     })

crates/frontend-promql/tests/univmon_candidates.rs

@@ -1,6 +1,7 @@
 use std::rc::Rc;
 
-use asap_logical_asap_optimization::accuracy::{AccuracyModel, DefaultAccuracyModel};
+use asap_logical_asap_optimization::accuracy::estimators::local_guarantee;
+use asap_logical_asap_optimization::accuracy::satisfies;
 mod support;
 use asap_types::ir::cse::share_common_sub_dags;
 use asap_types::ir::properties::AccuracyMetric;
@@ -88,9 +89,7 @@ fn four_evaluations_size_their_value_frequency_states_and_keep_honest_guarantees
                     Some(true)
                 );
                 assert_eq!(guarantee.spec.failure_probability.evaluate(), None);
-                assert!(DefaultAccuracyModel
-                    .local_guarantee(family, query)
-                    .is_none());
+                assert!(local_guarantee(family, query).is_none());
             }
             1 => {
                 assert!(matches!(
@@ -102,7 +101,7 @@ fn four_evaluations_size_their_value_frequency_states_and_keep_honest_guarantees
             2 => {
                 let guarantee = guarantee.expect("an L2 guarantee");
                 assert_eq!(guarantee.spec.accuracy_metric, AccuracyMetric::Relative);
-                assert!(DefaultAccuracyModel.satisfies(
+                assert!(satisfies(
                     guarantee,
                     &AccuracyTarget::max_error(0.02).accuracy_metric(AccuracyMetric::Relative)
                 ));
@@ -111,9 +110,7 @@ fn four_evaluations_size_their_value_frequency_states_and_keep_honest_guarantees
             // Entropy has no certified bound, so composition certifies nothing.
             _ => {
                 assert!(guarantee.is_none());
-                assert!(DefaultAccuracyModel
-                    .local_guarantee(family, query)
-                    .is_none());
+                assert!(local_guarantee(family, query).is_none());
             }
         }
         post_asap_dag(root);

crates/integration-tests/tests/promql_to_post_asap.rs

@@ -11,8 +11,9 @@ use std::rc::Rc;
 use asap_integration_tests::fixtures::lower_promql;
 use asap_integration_tests::planning::logical_candidates;
 use asap_integration_tests::post_asap::{at_ingestion, at_ingestion_post_asap_dag, post_asap_dag};
-use asap_logical_asap_optimization::accuracy::{AccuracyEvidenceProvider, OperandDomain};
+use asap_logical_asap_optimization::accuracy::OperandDomain;
 use asap_physical_asap_optimization::PhysicalCandidate;
+use asap_plan_selection::AccuracyEvidenceProvider;
 use asap_plan_selection::PlanningModels;
 use asap_plan_selection::Selection;
 use asap_types::ir::operator::operator_properties::Reduction;