You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deployment inputs: one bundle for cost model, accuracy model and capabilities — after #511 #525
#509 (Goal; "3. Plan selection") says the deployment supplies an empirical cost model, an empirical accuracy model and its execution capabilities, and selection rejects candidates needing a missing capability. The input structure is a TODO in #509.
Blocked on
Implementation of #511 (unified operator graph). Do not start before #511 is implemented.
three CostModel hooks (value_operation_capabilities → supports_value_operation → value_operation_support_evidence)
ALL
summary_support_evidence
cost_model.rs:882
CostModel hook
None
Notes:
SummaryMaintenanceCapabilities is planner knowledge. Its docs say it describes what the summary algorithm can do, not what the deployment can do.
ASAPQuery-backend still pins Planner rev f46cbf6c. It overrides value_operation_capabilities with the old field names and summary_maintenance_capabilities, and builds SummaryMaintenanceLifecycleCapabilities directly. Changes here only reach it when it bumps the pin.
Proposed (one concern per PR)
Move capabilities: SummaryMaintenanceLifecycleCapabilities from LifecycleInput into PlanningModels, with with_capabilities(); builtin() uses ALL. PlanningModels then becomes the single deployment-input bundle, and LifecycleInput keeps only the clock and horizon. No new struct. About 40 lines. Test: MajorPass with continuous-only capabilities rejects the other lifecycles with UnsupportedByRuntime.
Later: derive SummaryMaintenanceCapabilities from the physical kernels instead of a CostModel hook.
Later: collapse the three value-operation capability hooks into one.
Open questions
Rename PlanningModels (e.g. DeploymentInputs)? Recommended: no for now.
Status: covered by the upcoming deployment-inputs work (deployment inputs, capabilities and calibration). Not closing yet.
On main, PlanningModels { cost, accuracy, evidence } (crates/asap-aware-mapping/src/pass/mod.rs) is the deployment-input bundle. Stage 3 reads accuracy and evidence. Capabilities and a cost calibration are not inputs yet: Stage 3 prices with a fixed illustrative_calibration(), and its module doc says deployment capabilities are not checked yet. The lifecycle capability types this issue lists were removed with the lifecycle model (#667).
Activity
zzylol commentedon Oct 15, 2026
Status: covered by the upcoming deployment-inputs work (deployment inputs, capabilities and calibration). Not closing yet.
On main,
PlanningModels { cost, accuracy, evidence }(crates/asap-aware-mapping/src/pass/mod.rs) is the deployment-input bundle. Stage 3 readsaccuracyandevidence. Capabilities and a cost calibration are not inputs yet: Stage 3 prices with a fixedillustrative_calibration(), and its module doc says deployment capabilities are not checked yet. The lifecycle capability types this issue lists were removed with the lifecycle model (#667).