Skip to content

Upgrade mediawiki-codesniffer to 52 to unblock Composer - #53

Merged
JeroenDeDauw merged 1 commit into
masterfrom
fix/ci-codesniffer-advisory
Aug 17, 2026
Merged

Upgrade mediawiki-codesniffer to 52 to unblock Composer#53
JeroenDeDauw merged 1 commit into
masterfrom
fix/ci-codesniffer-advisory

Conversation

@JeroenDeDauw

Copy link
Copy Markdown
Member

Composer refuses to install php_codesniffer 3.12.2 (CVE-2026-67434), which mediawiki-codesniffer 47 pins, so every job
resolving the extension's own dependencies fails. Version 52 pins the patched 3.13.6, but requires PHP 8.3, so the
standalone unit job drops it on its minimum-PHP leg. Its new property-annotation sniff needs one exclusion for our
@psalm-suppress.

AI-authored — Claude Code, Opus 5 (max); one-line ask from @JeroenDeDauw, no revisions; diff not yet human-reviewed; phpcs, PHPStan, Psalm and the unit suite run locally against MW 1.43, and Composer resolution simulated for both the 8.1 and 8.3 legs.

Composer refuses to install php_codesniffer 3.12.2 (CVE-2026-67434), which
mediawiki-codesniffer 47 pins, so every job resolving the extension's own
dependencies fails. Version 52 pins the patched 3.13.6, but requires PHP 8.3,
so the standalone unit job drops it on its minimum-PHP leg. Its new
property-annotation sniff needs one exclusion for our @psalm-suppress.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (a96144d) to head (d7a694d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     83.41%   83.41%           
  Complexity      416      416           
=========================================
  Files            40       40           
  Lines          1067     1067           
=========================================
  Hits            890      890           
  Misses          177      177           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeroenDeDauw
JeroenDeDauw marked this pull request as ready for review August 17, 2026 23:10
@JeroenDeDauw
JeroenDeDauw merged commit 455e64f into master Aug 17, 2026
12 checks passed
@JeroenDeDauw
JeroenDeDauw deleted the fix/ci-codesniffer-advisory branch August 17, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants