Skip to content

feat(web): add dedicated VLC integration section with Linux support#473

Merged
ProdigyV21 merged 2 commits into
ProdigyV21:mainfrom
Himanth-reddy:feat/vlc-settings-integration
Jul 23, 2026
Merged

feat(web): add dedicated VLC integration section with Linux support#473
ProdigyV21 merged 2 commits into
ProdigyV21:mainfrom
Himanth-reddy:feat/vlc-settings-integration

Conversation

@Himanth-reddy

Copy link
Copy Markdown
Collaborator

This pull request adds comprehensive cross-platform VLC integration to the settings UI, allowing users to enable direct vlc:// protocol launching from the browser across Windows, Linux, macOS, Android, and iOS. It introduces a new settings section for VLC, setup scripts for Windows and Linux, and UI for testing and managing VLC protocol handler status.

Key changes:

VLC Integration UI and Logic:

  • Added a new "VLC Integration" section to the settings screen, including a custom VlcIcon, protocol handler status, integration check, and download buttons for setup scripts. The section provides platform-specific setup instructions and allows users to test and toggle protocol handler readiness. (web/components/settings/SettingsScreen.tsx) [1] [2] [3]
  • Updated imports to include new icons and helper functions for VLC integration. (web/components/settings/SettingsScreen.tsx) [1] [2]

Platform Detection and Setup Scripts:

  • Added isLinux() utility and VLC_SETUP_SH_URL constant for Linux support. (web/lib/externalPlayers.ts)
  • Added a new Linux setup script (vlc-setup.sh) that creates a protocol handler for vlc:// links using xdg-mime and a .desktop entry. (web/public/vlc-setup.sh)
  • Updated Netlify configuration to serve the Linux setup script with correct headers. (web/netlify.toml)

Miscellaneous:

  • Bumped the version number in version.json to reflect the new release. (web/public/version.json)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6dcc47916b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/public/vlc-setup.sh Outdated
Comment on lines +32 to +33
if [[ "$URL" =~ ^(https?)([^/].*) ]]; then
URL="${BASH_REMATCH[1]}://${BASH_REMATCH[2]}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix Linux handler rewriting valid HTTPS URLs

On Linux after running vlc-setup.sh, normal ARVIO stream launches pass URLs like vlc://https://... into this handler. After the prefix strip that becomes https://..., but this regex still matches because : satisfies [^/], so line 33 rewrites it to https://://...; Chrome-style https//... is also rewritten to http://s//.... VLC then receives a malformed URL, so direct VLC launching fails for HTTPS streams. Restrict the repair to genuinely missing/collapsed separators instead of matching already-valid http(s):// URLs.

Useful? React with 👍 / 👎.

@ProdigyV21

Copy link
Copy Markdown
Owner
  1. Linux handler regex breaks every URL (critical). Chrome strips the inner colon (vlc://https//host/...), and your repair regex backtracks: https//cdn → http://s//cdn, and even clean https://cdn → https://://cdn. Replace with the normalization we shipped on Windows (see vlc-setup.bat on main):

Please test on a real machine with a URL containing ?token=...&x=1 before pushing.

  1. Test URL is dead. The Google gtv-videos-bucket link now 403s — VLC opens empty during the check. Use e.g. https://test-videos.co.uk/vids/bigbuckbunny/mp4/h264/720/Big_Buck_Bunny_720_10s_5MB.mp4 (verified working).

  2. Rebase on main. externalPlayers.ts + the VLC flow changed a lot this week: isMac() (macOS needs no setup — reflect that in the UI), Windows installer rewrite, setup hint now gated on isWindows().

Happy to merge once fixed — the blur-detection check is clever. 🙌

@Himanth-reddy
Himanth-reddy force-pushed the feat/vlc-settings-integration branch from 6dcc479 to 9a6c7c9 Compare July 23, 2026 05:59
@ProdigyV21
ProdigyV21 merged commit fafa0d5 into ProdigyV21:main Jul 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants