Skip to content

feat(plugin): support Nuvio JS scrapers and redesign settings UI#466

Merged
ProdigyV21 merged 4 commits into
ProdigyV21:mainfrom
Himanth-reddy:feature/nuvio-plugin-fixes-redesign
Jul 23, 2026
Merged

feat(plugin): support Nuvio JS scrapers and redesign settings UI#466
ProdigyV21 merged 4 commits into
ProdigyV21:mainfrom
Himanth-reddy:feature/nuvio-plugin-fixes-redesign

Conversation

@Himanth-reddy

Copy link
Copy Markdown
Collaborator

This PR fixes compatibility for Nuvio JS scraper plugins and redesigns the Plugins settings UI to align with other screens.

@Himanth-reddy Himanth-reddy linked an issue Jul 21, 2026 that may be closed by this pull request
@Himanth-reddy
Himanth-reddy marked this pull request as ready for review July 22, 2026 00:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5e6b61e9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/build.gradle.kts Outdated

// Build config fields for release
buildConfigField("Boolean", "ENABLE_CRASH_REPORTING", "true")
buildConfigField("Boolean", "FEATURE_PLUGINS_ENABLED", "false")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Don’t override the sideload plugin flag in release

For sideloadRelease (and staging via initWith(release)), this build-type FEATURE_PLUGINS_ENABLED=false takes precedence over the sideload flavor’s FEATURE_PLUGINS_ENABLED=true, so the generated BuildConfig disables plugins in release-grade sideload APKs. SettingsScreen only adds the Plugins section when this flag is true, so production sideload users lose the UI needed to add or manage the Nuvio scrapers this change is adding; keep the flag flavor-scoped or set it true for sideload release variants.

Useful? React with 👍 / 👎.

@ProdigyV21

ProdigyV21 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Is this finished or you still working on it? I looked at it and these are my findings so far.

Findings
[P1] It conflicts with current main. The conflict is in SettingsScreen.kt between catalog-pack modal handling and the new plugin modal handling. Rebase and preserve both conditions.

[P1] Plugins are disabled in production sideload builds. app/build.gradle.kts:125 overrides FEATURE_PLUGINS_ENABLED to false for release and staging. I confirmed:
Sideload Debug: true
Sideload Release/Staging: false
Remove those build-type overrides and retain the existing flavor values: Play false, Sideload true.

[P2] Mobile opens the wrong settings page. SettingsScreen.kt:3900 routes both “Addons” and “Plugins & Extensions” to the Stremio addons screen. Mobile cannot access the redesigned plugin screen.

[P2] Reset does not completely unload extensions. ExternalExtensionLoader.kt:661 deletes files and caches, but extension extractors already registered globally can remain active until the app restarts.

[P2] Reset can leave TV focus out of range. After clearing a long plugin list, the selected index is not reset or clamped, temporarily leaving no visible focused row.

@Himanth-reddy
Himanth-reddy force-pushed the feature/nuvio-plugin-fixes-redesign branch from b5e6b61 to 0c8f60a Compare July 23, 2026 06:36
@Himanth-reddy

Copy link
Copy Markdown
Collaborator Author

I thought i would get some response from the testers but they didn't so let them complain in the next update.

@ProdigyV21
ProdigyV21 merged commit ebfe275 into ProdigyV21:main Jul 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuvio JS scraper repository installs but returns no sources

2 participants