feat(plugin): support Nuvio JS scrapers and redesign settings UI#466
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5e6b61e9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Build config fields for release | ||
| buildConfigField("Boolean", "ENABLE_CRASH_REPORTING", "true") | ||
| buildConfigField("Boolean", "FEATURE_PLUGINS_ENABLED", "false") |
There was a problem hiding this comment.
Don’t override the sideload plugin flag in release
For sideloadRelease (and staging via initWith(release)), this build-type FEATURE_PLUGINS_ENABLED=false takes precedence over the sideload flavor’s FEATURE_PLUGINS_ENABLED=true, so the generated BuildConfig disables plugins in release-grade sideload APKs. SettingsScreen only adds the Plugins section when this flag is true, so production sideload users lose the UI needed to add or manage the Nuvio scrapers this change is adding; keep the flag flavor-scoped or set it true for sideload release variants.
Useful? React with 👍 / 👎.
|
Is this finished or you still working on it? I looked at it and these are my findings so far. Findings [P1] Plugins are disabled in production sideload builds. app/build.gradle.kts:125 overrides FEATURE_PLUGINS_ENABLED to false for release and staging. I confirmed: [P2] Mobile opens the wrong settings page. SettingsScreen.kt:3900 routes both “Addons” and “Plugins & Extensions” to the Stremio addons screen. Mobile cannot access the redesigned plugin screen. [P2] Reset does not completely unload extensions. ExternalExtensionLoader.kt:661 deletes files and caches, but extension extractors already registered globally can remain active until the app restarts. [P2] Reset can leave TV focus out of range. After clearing a long plugin list, the selected index is not reset or clamped, temporarily leaving no visible focused row. |
…sable flag in release builds
…s for plugins screen
…ars, and remove scraper safety warning popups
…unload extractors, and clamp TV focus
b5e6b61 to
0c8f60a
Compare
|
I thought i would get some response from the testers but they didn't so let them complain in the next update. |
This PR fixes compatibility for Nuvio JS scraper plugins and redesigns the Plugins settings UI to align with other screens.