feat(notifications): add in-app notification bell for goals and streaks#411
feat(notifications): add in-app notification bell for goals and streaks#411mallya-m wants to merge 2 commits into
Conversation
|
@mallya-m is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Priyanshu-byte-coder |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
1. Missing migration file — PR description says it created the notifications table but no supabase/migrations/ file is in the diff. The API will throw on every request in any fresh deployment. Include the migration.
2. /notifications page doesn't exist — the "See all notifications" link points to a 404. Remove it or create the page.
3. Unrelated file changes — BadgeSection.tsx and CommitTimeChart.tsx are modified with changes unrelated to notifications (removing the Tip box, changing button colors). These belong in separate PRs.
4. Hardcoded text-white on the unread count badge — use text-[var(--accent-foreground)].
5. Missing EOF newlines on route.ts and NotificationBell.tsx.
What does this PR do?
Adds a notification bell icon to the dashboard header that shows unread
notification count and a dropdown list of recent notifications.
Related issue
Closes #232
Changes made
notificationsSupabase table with user_id, type, message, read, created_atGET /api/notificationsendpoint — returns 10 most recent + unread countPATCH /api/notificationsendpoint — marks all as readNotificationBell.tsxcomponent with bell icon, unread badge, dropdownHow to test
Screenshots