fix(TopRepos): show repo description as native tooltip on name hover (#214)#410
Open
Jyoti1-pog wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #214 —
TopReposlisted repository names but never surfaced thedescription the GitHub API already returns. Hovering a repo name now shows
its description as a native browser tooltip. Repos with no description
(
nullor"") correctly show no tooltip at all.Changes
src/components/TopRepos.tsx— addeddescription: string | nulltothe
Repotype; set the repo name link'stitle={repo.description || undefined}.src/app/api/metrics/repos/route.ts— threadeddescriptionthroughthe GitHub search response type, the
repoMapprojection, theRepoSummarytype, and the multi-accountmergeRepoCommitsmerge. Thefield was being dropped at every step of the API → component pipeline.
Using
|| undefined(not"") makes React omit thetitleattributeentirely when there is no description, so no empty tooltip renders.
Verification
Confirmed against the live GitHub API that
search/commitsreturnsrepository.description, and verified end-to-end on the dashboard that arepo with a description shows the tooltip while a repo with a
nulldescription shows none.
Tooltip shows on hover (repo with a description):
No tooltip (repo with null/empty description):
Note
The repo name link previously had
title={repo.name}(fullorg/repopath on hover). An element can carry only one
title, and the issueexplicitly specifies
title={repo.description || undefined}on the nameelement, so that prior tooltip is now replaced by the description — this is
the behaviour the issue asks for.
Closes #214