fix(ui): implement exact absolute coordinate alignment for month labels on heatmap#402
Merged
Merged
Conversation
|
@Visaka123 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
Priyanshu-byte-coder
approved these changes
May 20, 2026
Owner
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Fix is correct — switching from grid-based to absolute positioning for month labels solves the alignment problem. The gridRow reindex, setLastUpdated moved to .then(), and totalGridWidth calculation are all sound. One note for follow-up: clean up the hyperbolic comments ("100% MATHEMATICALLY PRECISE...") — not production style. Merging.
5ce342d
into
Priyanshu-byte-coder:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses and resolves structural alignment anomalies affecting the **
ContributionHeatmap**month timeline headers. The original implementation relied on fluid layout constraints and implicit element distributions, leading to rendering drift and text truncation when months initiated mid-week or crossed chronological year boundaries.This refactor establishes a deterministic positioning matrix that maps text headers directly to the exact grid track indices utilized by the underlying canvas architecture.
Closes #249
Type of Change
Changes Made
1. Chronological State Transition Engine
cell.date.getDate() === 1) with an itemized matrix traversal check utilizing a strict unique tracking set (!seenMonths.has(monthKey)).2. Matrix Coordinate Harmonization
LABEL_WIDTH + weekIndex * (CELL_SIZE + CELL_GAP)3. Allocation and Truncation Guard
width: "auto"andmin-width: "max-content"layers to the absolute layout blocks to eliminate multi-column tracking collisions. Short-span labels (e.g., Jun, Jul) bleed naturally into subsequent empty tracking headers without visual string truncation (...).Intl.DateTimeFormatinstance globally. This removes redundant engine instantiations inside the raw loop iterations, significantly reducing garbage collection overhead and main-thread execution time.console.log) to keep production runtime terminal spaces pristine.How to Test
npm run dev).Screenshots
Checklist
npm run lintpasses locallynpm run type-check)