Skip to content

feat:visibility of main page improved and added styling to mainpage u…#395

Closed
Saqlain532 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
Saqlain532:feat/issue-343-visibility-of-mainpage-improved
Closed

feat:visibility of main page improved and added styling to mainpage u…#395
Saqlain532 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
Saqlain532:feat/issue-343-visibility-of-mainpage-improved

Conversation

@Saqlain532
Copy link
Copy Markdown

Summary

Improved the visibility and overall appearance of the main page content by updating the color scheme and enhancing the UI interactions.

Closes #343

Type of Change

  • [✓] Bug fix
  • [✓] New feature
  • Documentation update
  • [✓] Refactor / code cleanup

Changes Made

  • Updated the main page color combination to improve content visibility and readability
  • Added smoother and more modern UI interactions using Framer Motion
  • Implemented hover effects with background color transitions
  • Added scale animation on hover for interactive sections/cards
  • Improved overall visual consistency of the page
  • Maintained responsive behavior across layouts
  • Verified that all modified code passes ESLint checks

How to Test

Steps for the reviewer to verify this works:

  1. Clone the branch and install dependencies using npm install

  2. Run the development server using npm run dev

  3. Open the main page in the browser

  4. Verify improved text visibility and updated color scheme

  5. Hover over interactive sections/cards and verify:

    • background color transition
    • smooth scale animation
  6. Run npm run lint to verify no lint issues in the modified code

Screenshots (if UI change)

Before
Screenshot 2026-05-19 074517

After
Screenshot 2026-05-19 195431

Checklist

  • [✓] Linked issue in summary
  • [✓] npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • [✓] Self-reviewed the diff
  • Added/updated tests if applicable

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@Saqlain532 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR on DevTrack! 🎉

A maintainer will review it within 48 hours. While you wait:

  • Make sure CI is passing (type-check + lint)
  • Double-check the PR description is filled out and the issue is linked
  • Feel free to ask questions in Discussions if you need help

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three issues blocking merge:

1. framer-motion adds too much bundle weight for landing page animations
framer-motion is ~100KB gzipped just for fade-in animations on a static landing page. The project uses Tailwind CSS for transitions. Replace motion.div with Tailwind's animate- / transition utilities — e.g., a simple fade-in can be done with:

<div className="animate-in fade-in duration-500 slide-in-from-bottom-4">

Or add a @keyframes rule in globals.css. No new runtime dependency needed. Remove framer-motion from package.json.

2. Conflicts with already-merged page.tsx improvements (PR #267)
This PR's base is the old page.tsx. PR #267 (already merged) reworked the landing page with CSS vars and an improved feature grid. After rebasing, this will conflict heavily — merge the two approaches instead of overwriting #267's work.

3. Hardcoded colors

  • bg-white text-slate-900 on the GitHub sign-in button → use bg-[var(--card)] text-[var(--card-foreground)]
  • hover:bg-slate-100 on both buttons → use hover:bg-[var(--control)]

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Closing — build-breaking changes unrelated to the stated goal:

  • next@^16.2.6 does not exist (latest is 15.x) — npm install will fail
  • "jsx": "react-jsx" in tsconfig breaks Next.js (requires "preserve")
  • lint script changed from next lint to eslint — breaks CI

The cosmetic improvements (button CSS var fixes, hover animations) are welcome — please resubmit those without the invalid dependency bumps and config changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The visibility of main page can be improved

2 participants