feat:visibility of main page improved and added styling to mainpage u…#395
Conversation
|
@Saqlain532 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Three issues blocking merge:
1. framer-motion adds too much bundle weight for landing page animations
framer-motion is ~100KB gzipped just for fade-in animations on a static landing page. The project uses Tailwind CSS for transitions. Replace motion.div with Tailwind's animate- / transition utilities — e.g., a simple fade-in can be done with:
<div className="animate-in fade-in duration-500 slide-in-from-bottom-4">Or add a @keyframes rule in globals.css. No new runtime dependency needed. Remove framer-motion from package.json.
2. Conflicts with already-merged page.tsx improvements (PR #267)
This PR's base is the old page.tsx. PR #267 (already merged) reworked the landing page with CSS vars and an improved feature grid. After rebasing, this will conflict heavily — merge the two approaches instead of overwriting #267's work.
3. Hardcoded colors
bg-white text-slate-900on the GitHub sign-in button → usebg-[var(--card)] text-[var(--card-foreground)]hover:bg-slate-100on both buttons → usehover:bg-[var(--control)]
|
Closing — build-breaking changes unrelated to the stated goal:
The cosmetic improvements (button CSS var fixes, hover animations) are welcome — please resubmit those without the invalid dependency bumps and config changes. |
Summary
Improved the visibility and overall appearance of the main page content by updating the color scheme and enhancing the UI interactions.
Closes #343
Type of Change
Changes Made
How to Test
Steps for the reviewer to verify this works:
Clone the branch and install dependencies using
npm installRun the development server using
npm run devOpen the main page in the browser
Verify improved text visibility and updated color scheme
Hover over interactive sections/cards and verify:
Run
npm run lintto verify no lint issues in the modified codeScreenshots (if UI change)
Before

After

Checklist
npm run lintpasses locallynpm run type-check)