fix: make javacheck work down to java 5#1
Conversation
jdk 8 allows target and source down to java 5, so why not Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
Huh? It was already being built for Java 7 lol Is there much point to this if it won't launch because of NewLaunch anyway? (somehow I think getting NewLaunch to work on Java 5 wouldn't be much fun, I don't actually know how many features it's lacking but it was the first one with generics xD) |
Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
even if branch name isn't main Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
i was so convinced it was being built against java8 for some reason, just realized it isn't xD (maybe because of this commit message DioEgizio@6b8aafa ???) but yeah running down to java 7 isn't very useful except for fixing things like PrismLauncher/PrismLauncher#4762 |
|
Ah that's annoying I guess if you need to uninstall those versions (though they are probably pretty insecure)
I think the reason I updated it to Java 8 is that it couldn't find temurin for Java 7 xD |
|
Are we ever going to use this in the launcher anyway though? |
maybe if we wanna switch away from having java code in-launcher and we wanna move everything to meta :/ |
also adds reuse because why not