Skip to content

Comments

fix: make javacheck work down to java 5#1

Merged
TheKodeToad merged 4 commits intoPrismLauncher:mainfrom
DioEgizio:main
Feb 16, 2026
Merged

fix: make javacheck work down to java 5#1
TheKodeToad merged 4 commits intoPrismLauncher:mainfrom
DioEgizio:main

Conversation

@DioEgizio
Copy link
Member

@DioEgizio DioEgizio commented Feb 15, 2026

also adds reuse because why not

jdk 8 allows target and source down to java 5, so why not

Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
@TheKodeToad
Copy link
Member

this makes it on par with the launcher one as it brings back support for java 7

Huh? It was already being built for Java 7 lol

Is there much point to this if it won't launch because of NewLaunch anyway? (somehow I think getting NewLaunch to work on Java 5 wouldn't be much fun, I don't actually know how many features it's lacking but it was the first one with generics xD)

Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
even if branch name isn't main

Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
@DioEgizio
Copy link
Member Author

Huh? It was already being built for Java 7 lol

i was so convinced it was being built against java8 for some reason, just realized it isn't xD (maybe because of this commit message DioEgizio@6b8aafa ???)

but yeah running down to java 7 isn't very useful except for fixing things like PrismLauncher/PrismLauncher#4762

@TheKodeToad
Copy link
Member

Ah that's annoying I guess if you need to uninstall those versions (though they are probably pretty insecure)

maybe because of this commit message

I think the reason I updated it to Java 8 is that it couldn't find temurin for Java 7 xD

@TheKodeToad
Copy link
Member

Are we ever going to use this in the launcher anyway though?

@TheKodeToad TheKodeToad merged commit b95051c into PrismLauncher:main Feb 16, 2026
2 checks passed
@DioEgizio
Copy link
Member Author

Are we ever going to use this in the launcher anyway though?

maybe if we wanna switch away from having java code in-launcher and we wanna move everything to meta :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants