Skip to content

[v0.8 replacement 4/5] consume canonical ACP transcripts - #2327

Open
sethkarten wants to merge 3 commits into
v080/main-replacement-harness-lifecyclefrom
v080/main-replacement-canonical-transcripts
Open

[v0.8 replacement 4/5] consume canonical ACP transcripts#2327
sethkarten wants to merge 3 commits into
v080/main-replacement-harness-lifecyclefrom
v080/main-replacement-canonical-transcripts

Conversation

@sethkarten

@sethkarten sethkarten commented Aug 11, 2026

Copy link
Copy Markdown

Replacement stack

Node 4/5 in a fresh append-only v0.8 replacement chain rooted at authoritative main commit c2820d3679e6318f9c3d0155c823d6908b4e1faa.

  • Base branch: v080/main-replacement-harness-lifecycle
  • Head branch: v080/main-replacement-canonical-transcripts
  • Exact head: 8edc72bcba53a277d1742b46b2ffe8ac625f1903

Scope

Exact coherent #2320 canonical transcript delta: two test paths; fixture SHA pinned.

The old contributor PR branches remain untouched. This branch was published non-force from a fresh owned repository. Independent Luna semantic review APPROVED the full N1→N5 chain and found no structural scope leakage; authoritative-main renderer provenance is retained and pyproject.toml / uv.lock are unchanged across replacement nodes.

Warning

TEST BLOCKED — do not merge or mark ready. Authoritative c2820d has a stale uv.lock relative to pyproject.toml. A disposable uv sync --locked correctly refused before tests, without changing repository files. The only previously approved interpreter also cannot import current main because pydantic_config is absent. Testing/remediation continues on GitHub; this draft does not claim green.

No live, hosted, Docker, sandbox, model, or paid evaluation was run.

Note

Add canonical ACP transcript fixture and tests for runner metadata storage

  • Adds a canonical ACP correlation transcript fixture (acp-correlation-transcripts.json) with six named cases: success, error_terminal, error_incomplete, cancelled, late_child, and global_sequence_turn_two.
  • Adds tests in test_acp.py that enforce exact fixture bytes via SHA-256 digest, validate event ordering and fields per case, and verify that events sent to the runner's VerifiersACPClient are stored correctly in acp_meta and turn_acp_meta.
  • The fixture integrity check uses a hardcoded SHA-256 digest, so any change to the fixture file will fail the test until the digest constant is updated.

Macroscope summarized 091948c.


Note

Low Risk
Test-only changes with no production or runtime behavior modifications.

Overview
Adds canonical ACP correlation transcript coverage for the ai.primeintellect.prime-agent/v1 schema: a new fixture tests/v1/fixtures/acp-correlation-transcripts.json with six named cases (success, error_terminal, error_incomplete, cancelled, late_child, global_sequence_turn_two), including notes that end_turn is intentionally omitted.

tests/v1/test_acp.py loads that fixture with a pinned SHA-256 on the raw bytes, asserts the full case set and per-case phase/outcome/quiescence shapes, and adds a parametrized async test that replays each transcript through VerifiersACPClient.session_update (via the stub-loaded runner) and checks acp_meta / turn_acp_meta match the fixture, with expected responseBoundary / terminalQuiescence terminal evidence per case (including empty terminal lists for cancelled and late_child).

Reviewed by Cursor Bugbot for commit 091948c. Bugbot is set up for automated code reviews on this repo. Configure here.

@sethkarten
sethkarten marked this pull request as ready for review August 12, 2026 06:18
@macroscopeapp

macroscopeapp Bot commented Aug 12, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved 8edc72b

Test-only changes: adds a JSON fixture file and corresponding tests for ACP transcript handling. No production code or runtime behavior is affected.

No code changes detected at 091948c. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant