[v0.8 replacement 4/5] consume canonical ACP transcripts - #2327
Open
sethkarten wants to merge 3 commits into
Open
[v0.8 replacement 4/5] consume canonical ACP transcripts#2327sethkarten wants to merge 3 commits into
sethkarten wants to merge 3 commits into
Conversation
sethkarten
marked this pull request as ready for review
August 12, 2026 06:18
ApprovabilityVerdict: Approved 8edc72b Test-only changes: adds a JSON fixture file and corresponding tests for ACP transcript handling. No production code or runtime behavior is affected. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement stack
Node 4/5 in a fresh append-only v0.8 replacement chain rooted at authoritative
maincommitc2820d3679e6318f9c3d0155c823d6908b4e1faa.v080/main-replacement-harness-lifecyclev080/main-replacement-canonical-transcripts8edc72bcba53a277d1742b46b2ffe8ac625f1903Scope
Exact coherent #2320 canonical transcript delta: two test paths; fixture SHA pinned.
The old contributor PR branches remain untouched. This branch was published non-force from a fresh owned repository. Independent Luna semantic review APPROVED the full N1→N5 chain and found no structural scope leakage; authoritative-main renderer provenance is retained and
pyproject.toml/uv.lockare unchanged across replacement nodes.Warning
TEST BLOCKED — do not merge or mark ready. Authoritative
c2820dhas a staleuv.lockrelative topyproject.toml. A disposableuv sync --lockedcorrectly refused before tests, without changing repository files. The only previously approved interpreter also cannot import current main becausepydantic_configis absent. Testing/remediation continues on GitHub; this draft does not claim green.No live, hosted, Docker, sandbox, model, or paid evaluation was run.
Note
Add canonical ACP transcript fixture and tests for runner metadata storage
success,error_terminal,error_incomplete,cancelled,late_child, andglobal_sequence_turn_two.VerifiersACPClientare stored correctly inacp_metaandturn_acp_meta.Macroscope summarized 091948c.
Note
Low Risk
Test-only changes with no production or runtime behavior modifications.
Overview
Adds canonical ACP correlation transcript coverage for the
ai.primeintellect.prime-agent/v1schema: a new fixturetests/v1/fixtures/acp-correlation-transcripts.jsonwith six named cases (success,error_terminal,error_incomplete,cancelled,late_child,global_sequence_turn_two), including notes thatend_turnis intentionally omitted.tests/v1/test_acp.pyloads that fixture with a pinned SHA-256 on the raw bytes, asserts the full case set and per-case phase/outcome/quiescence shapes, and adds a parametrized async test that replays each transcript throughVerifiersACPClient.session_update(via the stub-loaded runner) and checksacp_meta/turn_acp_metamatch the fixture, with expectedresponseBoundary/terminalQuiescenceterminal evidence per case (including empty terminal lists forcancelledandlate_child).Reviewed by Cursor Bugbot for commit 091948c. Bugbot is set up for automated code reviews on this repo. Configure here.